HomePhabricator

[rpc] Deprecate estimatefee RPC

Description

[rpc] Deprecate estimatefee RPC

Summary:
Deprecate estimatefee in v0.16, for final removal in v0.17.

This commit introduces a phased removal of RPC methods. RPC method is
disabled by default in version x, but can be enabled by using the
-deprecatedrpc=<method> argument. RPC method is removed entirely in
version (x+1).

[rpc] [tests] Add deprecated RPC test

This is a backport of Core PR11031

Test Plan:

make check
./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1920

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Aug 11 2017, 15:25
deadalnixCommitted on Oct 14 2018, 19:05
schancelPushed on Oct 14 2018, 22:17
Reviewer
Restricted Project
Differential Revision
D1920: [rpc] Deprecate estimatefee RPC
Parents
rSTAGING6d742d39e1e9: Fix some chainstate-init-order bugs.
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/5416, tag: phabricator/base/5415
Reverted By
rSTAGINGa4c86bad8530: [rpc] Undeprecate estimatefee