HomePhabricator

wallet: Disallow abandon of conflicted txes

Description

wallet: Disallow abandon of conflicted txes

Summary:

Abandon transactions that are already conflicted is a noop, so don't try
and return false/throw instead.

Backport of core PR12282
https://github.com/bitcoin/bitcoin/pull/12282/files

Test Plan:

make check
./test/functional/test_runner.py wallet_abandonconflict

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3497

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 27 2018, 22:45
FabienCommitted on Jul 1 2019, 13:17
deadalnixPushed on Jul 1 2019, 16:00
Reviewer
Restricted Project
Differential Revision
D3497: wallet: Disallow abandon of conflicted txes
Parents
rSTAGINGc469b47414cb: Fix a shadow warning in askpassphrasedialog.cpp
Branches
Unknown
Tags
Unknown