HomePhabricator

Add phpcs exclusion for strict_types declararion

Authored by jasonbcox on Tue, Oct 1, 17:51.

Description

Add phpcs exclusion for strict_types declararion

Summary: We are not yet compliant and newer versions of phpcs give linter failures, so we should exclude this for now.

Test Plan:

phpcs --version  # I'm running 3.5.0, which is newer and errors on strict_types
phpcs <any linter in /arcanist/linter/>  # Without patch: `1 | ERROR | Missing required strict_types declaration`
phpcs <any linter in /arcanist/linter/>  # With patch: (no error)

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4193

Details

Committed
jasonbcoxTue, Oct 1, 18:09
Pushed
jasonbcoxTue, Oct 1, 18:10
Reviewer
Restricted Project
Differential Revision
D4193: Add phpcs exclusion for strict_types declararion
Parents
rSTAGING93f8083a0621: Add static_assert to prevent VARINT(<signed value>)
Branches
Unknown
Tags
Unknown