Page MenuHomePhabricator

Add phpcs exclusion for strict_types declararion
ClosedPublic

Authored by jasonbcox on Oct 1 2019, 17:54.

Details

Summary

We are not yet compliant and newer versions of phpcs give linter failures, so we should exclude this for now.

Test Plan
phpcs --version  # I'm running 3.5.0, which is newer and errors on strict_types
phpcs <any linter in /arcanist/linter/>  # Without patch: `1 | ERROR | Missing required strict_types declaration`
phpcs <any linter in /arcanist/linter/>  # With patch: (no error)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.