Differential D4193

Add phpcs exclusion for strict_types declararion
ClosedPublic
Actions

Authored by jasonbcox on Oct 1 2019, 17:54.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING5ab2f96ed68d: Add phpcs exclusion for strict_types declararion
rABC5ab2f96ed68d: Add phpcs exclusion for strict_types declararion

Summary

We are not yet compliant and newer versions of phpcs give linter failures, so we should exclude this for now.

Test Plan

phpcs --version  # I'm running 3.5.0, which is newer and errors on strict_types
phpcs <any linter in /arcanist/linter/>  # Without patch: `1 | ERROR | Missing required strict_types declaration`
phpcs <any linter in /arcanist/linter/>  # With patch: (no error)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

phpcs-exclusion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7652
Build 13343: Bitcoin ABC Buildbot (legacy)
Build 13342: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 1 2019, 17:54

Herald added a reviewer: deadalnix. · View Herald TranscriptOct 1 2019, 17:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox mentioned this in D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.Oct 1 2019, 17:56

Fabien accepted this revision.Oct 1 2019, 17:56

This revision is now accepted and ready to land.Oct 1 2019, 17:56

Harbormaster completed remote builds in B7652: Diff 13297.Oct 1 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC5ab2f96ed68d: Add phpcs exclusion for strict_types declararion (authored by jasonbcox). · Explain WhyOct 1 2019, 18:10

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC5ab2f96ed68d: Add phpcs exclusion for strict_types declararion.

jasonbcox added a commit: rSTAGING5ab2f96ed68d: Add phpcs exclusion for strict_types declararion.Oct 9 2019, 20:10

Revision Contents
Changeset List

Path

Size

arcanist/

1 line

Diff 13297

arcanist/phpcs.xml

Loading...