HomePhabricator

Merge #13412: Make ReceivedBlockTransactions return void

Description

Merge #13412: Make ReceivedBlockTransactions return void

Summary:
fafa27032876832ab2ed9bf0e20e2d448f012179 Make ReceivedBlockTransactions return void (MarcoFalke)

Pull request description:

Instead of always returning `bool{true}` and forcing the caller to handle the return code, make it void and remove "a bunch" of dead code at the call sites.

Tree-SHA512: 10e41461c0516c0441d8b8eedcf6385874355c224b9e9d65e89addb142b4cf3e3be2d4ca0a7f2bd95c76aecdaa8537b6bd2d25631bf804bc42863ad5e84fa271

Backport of Core PR13415
https://github.com/bitcoin/bitcoin/pull/13412/

Test Plan:

make check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4771

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jun 18 2018, 15:17
nakihitoCommitted on Dec 20 2019, 19:27
deadalnixPushed on Dec 20 2019, 23:13
Reviewer
Restricted Owners Package
Differential Revision
D4771: Merge #13412: Make ReceivedBlockTransactions return void
Parents
rSTAGING205fe85a4cd7: Rename activation tests which are now feature tests
Branches
Unknown
Tags
Unknown