HomePhabricator

[backport] qa: Make tmpdir option an absolute path, misc cleanup

Description

[backport] qa: Make tmpdir option an absolute path, misc cleanup

Summary:
Backport of Core PR11472:

fafa003 qa: Remove never used return value of sync_with_ping (MarcoFalke)
fa9de37 qa: Make tmpdir option an absolute path (MarcoFalke)

Pull request description:

This should fix issues with the multiwallet test and its symlinks
when the tmpdir is a relative path.

Rather than fixing os.symlink to work with paths relative to a
directory descriptor, which does not work on Windows, normalize
the path instead.

Test Plan: ./test/functional/test_runner.py

Reviewers: matiu, deadalnix, #bitcoin_abc

Reviewed By: matiu, #bitcoin_abc

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1053

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Oct 9 2017, 22:04
schancelCommitted on Jan 31 2018, 21:10
schancelPushed on Jan 31 2018, 21:14
Reviewer
Restricted Project
Differential Revision
D1053: [backport] qa: Make tmpdir option an absolute path, misc cleanup
Parents
rSTAGINGf8f881f3c701: No longer ever reuse keypool indexes
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/2785, tag: phabricator/base/2784