Paths

Table of Contentst

[backport] qa: Make tmpdir option an absolute path, misc cleanup
ClosedPublic
Actions

Authored by schancel on Jan 30 2018, 23:47.

Details

Reviewers

matiu
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING646f65a34e1e: [backport] qa: Make tmpdir option an absolute path, misc cleanup
rABC646f65a34e1e: [backport] qa: Make tmpdir option an absolute path, misc cleanup

Summary

Backport of Core PR11472:

fafa003 qa: Remove never used return value of sync_with_ping (MarcoFalke)
fa9de37 qa: Make tmpdir option an absolute path (MarcoFalke)

Pull request description:

This should fix issues with the multiwallet test and its symlinks
when the tmpdir is a relative path.

Rather than fixing os.symlink to work with paths relative to a
directory descriptor, which does not work on Windows, normalize
the path instead.

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Jan 30 2018, 23:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 23:47

Harbormaster completed remote builds in B1783: Diff 2774.Jan 30 2018, 23:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matiu accepted this revision.Jan 31 2018, 00:13

This revision is now accepted and ready to land.Jan 31 2018, 00:13

Closed by commit rABC646f65a34e1e: [backport] qa: Make tmpdir option an absolute path, misc cleanup (authored by MarcoFalke <falke.marco@gmail.com>, committed by schancel). · Explain WhyJan 31 2018, 21:10

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p-acceptblock.py

11 lines

test_framework/

mininode.py

1 line

test_framework.py

3 lines

Diff 2782

View Options

test/functional/p2p-acceptblock.py

View Options

test/functional/test_framework/mininode.py

View Options

test/functional/test_framework/test_framework.py

[backport] qa: Make tmpdir option an absolute path, misc cleanupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2782

test/functional/p2p-acceptblock.py

test/functional/test_framework/mininode.py

test/functional/test_framework/test_framework.py

[backport] qa: Make tmpdir option an absolute path, misc cleanup
ClosedPublic
Actions

Revision Contents
Changeset List