Page MenuHomePhabricator
Differential D1053

[backport] qa: Make tmpdir option an absolute path, misc cleanup
ClosedPublic
Actions

Authored by schancel on Jan 30 2018, 23:47.

Details

Reviewers
matiu
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING646f65a34e1e: [backport] qa: Make tmpdir option an absolute path, misc cleanup
rABC646f65a34e1e: [backport] qa: Make tmpdir option an absolute path, misc cleanup
Summary

Backport of Core PR11472:

fafa003 qa: Remove never used return value of sync_with_ping (MarcoFalke)
fa9de37 qa: Make tmpdir option an absolute path (MarcoFalke)

Pull request description:

This should fix issues with the multiwallet test and its symlinks
when the tmpdir is a relative path.

Rather than fixing os.symlink to work with paths relative to a
directory descriptor, which does not work on Windows, normalize
the path instead.
Test Plan

./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abs-path-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1783
Build 1783: arc lint + arc unit

Revision Contents
Changeset List

PathSize
test/
functional/
11 lines
test_framework/
1 line
3 lines

Diff 2774

View Options

test/functional/p2p-acceptblock.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...