HomePhabricator

Fix merging of global unknown data in PSBTs

Description

Fix merging of global unknown data in PSBTs

Summary:
Actually merge the global unknown key-value pairs.

Add a test for merging unknown key-value pairs.

This is a partial backport of Core PR13721 : https://github.com/bitcoin/bitcoin/pull/13721/commits/fad231ad41e12b7047deb64220942ca8cb8357bc

Depends on D4456

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4457

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jul 20 2018, 01:49
deadalnixCommitted on Nov 18 2019, 13:36
deadalnixPushed on Nov 18 2019, 15:17
Reviewer
Restricted Project
Differential Revision
D4457: Fix merging of global unknown data in PSBTs
Parents
rSTAGINGd395b70087cb: Check that PSBT keys are the correct length
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/14180, tag: phabricator/base/14179