Page MenuHomePhabricator

Check that PSBT keys are the correct length
ClosedPublic

Authored by deadalnix on Nov 17 2019, 17:33.

Details

Summary

Checks that all of the one byte type keys are actually one byte and
throw an error if they are not.

Add tests for each type to check for this behavior.

This is a partial backport of Core PR13721 : https://github.com/bitcoin/bitcoin/pull/13721/commits/41df035ee1694715ee1e0f89b08ac8c73987807b

Depends on D4454

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Nov 18 2019, 08:44