Check that PSBT keys are the correct length
ClosedPublic
Actions

Authored by deadalnix on Nov 17 2019, 17:33.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd395b70087cb: Check that PSBT keys are the correct length
rABCd395b70087cb: Check that PSBT keys are the correct length

Summary

Checks that all of the one byte type keys are actually one byte and
throw an error if they are not.

Add tests for each type to check for this behavior.

This is a partial backport of Core PR13721 : https://github.com/bitcoin/bitcoin/pull/13721/commits/41df035ee1694715ee1e0f89b08ac8c73987807b

Depends on D4454

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13721

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

deadalnix created this revision.Nov 17 2019, 17:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2019, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8137: Diff 14163.Nov 17 2019, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added a child revision: D4457: Fix merging of global unknown data in PSBTs.Nov 17 2019, 17:46

Fabien accepted this revision.Nov 18 2019, 08:44

This revision is now accepted and ready to land.Nov 18 2019, 08:44

Closed by commit rABCd395b70087cb: Check that PSBT keys are the correct length (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 18 2019, 13:29

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd395b70087cb: Check that PSBT keys are the correct length.

deadalnix added a commit: rSTAGINGd395b70087cb: Check that PSBT keys are the correct length.Apr 7 2020, 21:42

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

21 lines

test/

functional/

data/

rpc_psbt.json

11 lines

Diff 14163

View Options

src/script/sign.h