HomePhabricator

[backport#14532] net: Always default rpcbind to localhost, never "all…

Description

[backport#14532] net: Always default rpcbind to localhost, never "all interfaces"

Summary:
We don't support binding to untrusted networks, so avoid a default where that is typical (luke-jr)

3615003952ffbc814bdb53d9d0e45790f152bd2f net: Always default rpcbind to localhost, never "all interfaces"
d6a1287481428d982dc03be3a6d9aeef8398f468 CNetAddr: Add IsBindAny method to check for INADDR_ANY
27c44ef9c61f64d941ab82ec232a68141a2fde90 rpcbind: Warn about exposing RPC to untrusted networks

f3cf95ffdfda935f28260eb34bf20c1449a200c5 tests: Modify rpc_bind to conform to #14532 behaviour.


This is a backport of Core PR14532 and Core PR14861

Test Plan:

ninja check
./test/functional/test_runner/rpc_bind

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5880

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Oct 20 2018, 14:37
majcostaCommitted on Apr 29 2020, 14:51
deadalnixPushed on Apr 29 2020, 15:25
Reviewer
Restricted Project
Differential Revision
D5880: [backport#14532] net: Always default rpcbind to localhost, never "all interfaces"
Parents
rSTAGING7677060b233d: Fix the emulator with autotools
Branches
Unknown
Tags
Unknown