HomePhabricator

[CMAKE] Install DLL to bin/ by default

Description

[CMAKE] Install DLL to bin/ by default

Summary:
The shared libraries are installed by CMake to lib/ by default, with
the exception of windows DLLs which are installed under bin/.
This behavior was changed in D4229 to reflect the location of the
delivered files from our release.

However it appears that the windows Gitian build is searching for the
DLL files in the bin/ directory, before copying it to lib/. This
workaround is then unnecessary as it is handled by Gitian, and can be
simply removed.

Test Plan:
Cross-build for Windows:

ninja install

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4403

Details

Provenance
FabienAuthored on Nov 6 2019, 15:48
FabienPushed on Nov 11 2019, 09:23
Reviewer
Restricted Project
Differential Revision
D4403: [CMAKE] Install DLL to bin/ by default
Parents
rSTAGING146f6e2a8079: [CMAKE] Complete the dist directory to prepare for the DMG image build
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/14045, tag: phabricator/base/14044