Page MenuHomePhabricator

[CMAKE] Install DLL to bin/ by default
ClosedPublic

Authored by Fabien on Wed, Nov 6, 20:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC755aac0bbfd6: [CMAKE] Install DLL to bin/ by default
Summary

The shared libraries are installed by CMake to lib/ by default, with
the exception of windows DLLs which are installed under bin/.
This behavior was changed in D4229 to reflect the location of the
delivered files from our release.

However it appears that the windows Gitian build is searching for the
DLL files in the bin/ directory, before copying it to lib/. This
workaround is then unnecessary as it is handled by Gitian, and can be
simply removed.

Test Plan

Cross-build for Windows:

ninja install

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Nov 6, 20:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 20:15
deadalnix accepted this revision.Sun, Nov 10, 12:55
This revision is now accepted and ready to land.Sun, Nov 10, 12:55
This revision was automatically updated to reflect the committed changes.