Page MenuHomePhabricator
Differential D4403

[CMAKE] Install DLL to bin/ by default
ClosedPublic
Actions

Authored by Fabien on Nov 6 2019, 20:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING755aac0bbfd6: [CMAKE] Install DLL to bin/ by default
rABC755aac0bbfd6: [CMAKE] Install DLL to bin/ by default
Summary

The shared libraries are installed by CMake to lib/ by default, with
the exception of windows DLLs which are installed under bin/.
This behavior was changed in D4229 to reflect the location of the
delivered files from our release.

However it appears that the windows Gitian build is searching for the
DLL files in the bin/ directory, before copying it to lib/. This
workaround is then unnecessary as it is handled by Gitian, and can be
simply removed.

Test Plan

Cross-build for Windows:

ninja install

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_dll_install_default
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8019
Build 14036: Bitcoin ABC Buildbot (legacy)
Build 14035: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 6 2019, 20:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2019, 20:15
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 6 2019, 20:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8019: Diff 13969.Nov 6 2019, 20:28
teamcity added a comment.Nov 6 2019, 20:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a child revision: D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.Nov 6 2019, 20:35
deadalnix accepted this revision.Nov 10 2019, 12:55
This revision is now accepted and ready to land.Nov 10 2019, 12:55
Closed by commit rABC755aac0bbfd6: [CMAKE] Install DLL to bin/ by default (authored by Fabien). · Explain WhyNov 11 2019, 09:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC755aac0bbfd6: [CMAKE] Install DLL to bin/ by default.
Fabien removed a child revision: D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.Nov 11 2019, 11:55
Fabien added a commit: rSTAGING755aac0bbfd6: [CMAKE] Install DLL to bin/ by default.Apr 7 2020, 21:40

Revision Contents
Changeset List

PathSize
cmake/
modules/
12 lines

Diff 13969

View Options

cmake/modules/InstallationHelper.cmake

Loading...