Page MenuHomePhabricator

[CMAKE] Migrate windows gitian build to cmake and ninja
AcceptedPublic

Authored by Fabien on Wed, Nov 6, 20:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Replace autotools by CMake for the windows Gitian builds, and use
Ninja as a generator.

Note 1:
The test_bitcoin binary is no longer part of the Gitian output.

Note 2: There are some more dependencies required.
This is because CMake is run for the native platform in order to build a
couple helper binaries for secp256k1 and univalue. CMake is run from the
project root and check for all the dependencies despite only a compiler
is required. This is a minor inconvenience which can be reworked later.

Depends on D4445.

Test Plan

Run the Windows Gitian build twice.
Check the hashes are identical between the builds.
Run the binaries and installers for both 32 bits and 64 bits
architectures.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian_win_cmake
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8143
Build 14319: Bitcoin ABC Buildbot
Build 14318: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Nov 6, 20:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 20:35
deadalnix requested changes to this revision.Sun, Nov 10, 12:57

You need to be using the depends libs and not the system's.

This revision now requires changes to proceed.Sun, Nov 10, 12:57
Fabien updated this revision to Diff 14047.Mon, Nov 11, 11:56

Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.

Fabien planned changes to this revision.Tue, Nov 12, 14:08
Fabien updated this revision to Diff 14100.Wed, Nov 13, 13:24

Rebase and add the wrappers to path.

Fabien planned changes to this revision.Wed, Nov 13, 13:24
Fabien updated this revision to Diff 14128.Thu, Nov 14, 10:39
Fabien edited the summary of this revision. (Show Details)

Rebase on top of D4445.

Fabien planned changes to this revision.Thu, Nov 14, 10:39
Fabien requested review of this revision.Thu, Nov 14, 10:54

The rebase fixed the determinism issue.

deadalnix requested changes to this revision.Sun, Nov 17, 23:06

See comments in D4356

This revision now requires changes to proceed.Sun, Nov 17, 23:06
Fabien updated this revision to Diff 14178.Mon, Nov 18, 14:44

Address comments from D4356 (they are applicable to this diff as well).

deadalnix accepted this revision.Tue, Nov 19, 23:37
This revision is now accepted and ready to land.Tue, Nov 19, 23:37