Page MenuHomePhabricator

[CMAKE] Avoid dependencies when building native bin during cross build
ClosedPublic

Authored by Fabien on Nov 11 2019, 11:51.

Details

Summary

The NativeExecutable.cmake module will run CMake from the top level
with all the default options, leading to some dependencies being
required while they is no use for it.
This will remove the need for most host side dependencies when running
the gitian builds with CMake.

Test Plan
ninja check

Cross build for any platform.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
cmake/modules/NativeExecutable.cmake
18 ↗(On Diff #14045)

nit: what initially threw me off was that these were any dependencies. after clarifying offline, I think the comment could be clarified to state that this is to reduce unneeded third-party dependencies specifically.

This revision is now accepted and ready to land.Nov 11 2019, 22:47