Diffusion Bitcoin ABC staging 79943feda175

Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards…
79943feda175Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations.

Summary: Fixes phabricator issue T56

Test Plan: make check on Ubuntu 14.04 / 14.05 (Travis equivalent)

Reviewers: #bitcoin_abc, deadalnix, freetrader, sickpig, kyuupichan, awemany, O1 Bitcoin ABC

Reviewed By: #bitcoin_abc, deadalnix, O1 Bitcoin ABC

Differential Revision: https://reviews.bitcoinabc.org/D290

Details

Provenance

CCulianu	Authored on Jul 2 2017, 10:16
schancel	Pushed on Jan 5 2018, 21:58
schancel	Pushed on Jan 5 2018, 21:39
schancel	Pushed on Jan 5 2018, 21:17

Reviewer

Restricted Project

Differential Revision

D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations.

Parents

rSTAGINGe0ec90e662e6: Align UAHF spec with upstream Bitcoin-UAHF

Branches

Unknown

Tags

Unknown

Event Timeline

CCulianu committed rSTAGING79943feda175: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards… (authored by CCulianu).Jul 2 2017, 13:14

Changes (1)

Path

Size

src/

test/

net_tests.cpp

rSTAGING79943feda175

View Options

Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards…79943feda175UnpublishedActions