HomePhabricator

Remove vchDefaultKey and have better first run detection

Description

Remove vchDefaultKey and have better first run detection

Summary:
Removes vchDefaultKey which was only used for first run detection.
Improves wallet first run detection by checking to see if any keys
were read from the database.

This will now also check for a valid defaultkey for backwards
compatibility reasons and to check for any corruption.

Keys will stil be generated on the first one, but there won't be
any shown in the address book as was previously done.

Backport core's PR10952

Depends on D1049

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, schancel

Reviewed By: #bitcoin_abc, schancel

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1051

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jul 29 2017, 00:00
deadalnixCommitted on Feb 1 2018, 00:41
matiuPushed on Feb 1 2018, 01:37
Reviewer
Restricted Project
Differential Revision
D1051: Remove vchDefaultKey and have better first run detection
Parents
rSTAGINGf546bb0d0e39: [wallet] Basic keypool topup
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/2789