HomePhabricator

[backport#15680] [rpc] remove resendwallettransactions RPC

Description

[backport#15680] [rpc] remove resendwallettransactions RPC

Summary:
This RPC was added for testing wallet rebroadcasts. Since we now have a
real test for wallet rebroadcasts, it's no longer needed.

The call in wallet_basic.py can be removed because
wallet_resendwallettransactions.py tests wallet rebroadcast.

https://github.com/bitcoin/bitcoin/pull/15680/commits/f5162458cd3e757ee6bbc7e963b61d365ccc536a


This is a partial backport of Core PR15680

Test Plan:

ninja check
./test_runner.py wallet_basic

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5951

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Mar 22 2019, 18:14
majcostaCommitted on May 5 2020, 09:55
majcostaPushed on May 5 2020, 12:40
Reviewer
Restricted Project
Differential Revision
D5951: [backport#15680] [rpc] remove resendwallettransactions RPC
Parents
rSTAGING3361af538cf2: wallet: Fixup rescanblockchain result doc
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/19434, tag: phabricator/base/19433