Page MenuHomePhabricator
Differential D5951

[backport#15680] [rpc] remove resendwallettransactions RPC
ClosedPublic
Actions

Authored by majcosta on May 4 2020, 19:11.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING92426570b6dc: [backport#15680] [rpc] remove resendwallettransactions RPC
rABC92426570b6dc: [backport#15680] [rpc] remove resendwallettransactions RPC
Summary

This RPC was added for testing wallet rebroadcasts. Since we now have a
real test for wallet rebroadcasts, it's no longer needed.

The call in wallet_basic.py can be removed because
wallet_resendwallettransactions.py tests wallet rebroadcast.

https://github.com/bitcoin/bitcoin/pull/15680/commits/f5162458cd3e757ee6bbc7e963b61d365ccc536a

This is a partial backport of Core PR15680

Test Plan
ninja check
./test_runner.py wallet_basic

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 4 2020, 19:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 19:11
majcosta requested review of this revision.May 4 2020, 19:11
teamcity edited the summary of this revision. (Show Details)May 4 2020, 19:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 4 2020, 19:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta planned changes to this revision.May 4 2020, 19:17
majcosta requested review of this revision.
teamcity added a comment.May 4 2020, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10577: Diff 19416.May 4 2020, 19:24
majcosta added a child revision: D5952: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore.May 4 2020, 19:28
jasonbcox accepted this revision.May 4 2020, 20:30
This revision is now accepted and ready to land.May 4 2020, 20:30
Closed by commit rABC92426570b6dc: [backport#15680] [rpc] remove resendwallettransactions RPC (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 5 2020, 09:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC92426570b6dc: [backport#15680] [rpc] remove resendwallettransactions RPC.
majcosta added a commit: rSTAGING92426570b6dc: [backport#15680] [rpc] remove resendwallettransactions RPC.May 5 2020, 19:19

Revision Contents
Changeset List

PathSize
src/
wallet/
51 lines
test/
functional/
17 lines

Diff 19430

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_basic.py

Loading...