Page MenuHomePhabricator
Differential D5952

[backport#15680] [wallet] Remove ResendWalletTransactionsBefore
ClosedPublic
Actions

Authored by majcosta on May 4 2020, 19:28.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING662edf2e7af1: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore
rABC662edf2e7af1: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore
Summary

This is only called from ResendWalletTransactions(), so bring it inline.

https://github.com/bitcoin/bitcoin/pull/15680/commits/ea1a2d8794ffb6b814e7120fb8ba0cc4aa7ebf3d

Depends on D5951

This completes the backport of Core PR15680

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 4 2020, 19:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 19:28
majcosta requested review of this revision.May 4 2020, 19:28
teamcity edited the summary of this revision. (Show Details)May 4 2020, 19:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 4 2020, 19:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 4 2020, 19:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10578: Diff 19417.May 4 2020, 19:38
jasonbcox requested changes to this revision.May 4 2020, 20:35
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/wallet.cpp
2276 ↗(On Diff #19417)

braces

This revision now requires changes to proceed.May 4 2020, 20:35
majcosta updated this revision to Diff 19429.EditedMay 5 2020, 09:52

added braces

edit: also rebased

teamcity added a comment.May 5 2020, 09:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 10:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10586: Diff 19429.May 5 2020, 10:02
deadalnix accepted this revision.May 5 2020, 14:07
jasonbcox accepted this revision.May 6 2020, 13:05
This revision is now accepted and ready to land.May 6 2020, 13:05
Closed by commit rABC662edf2e7af1: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 6 2020, 14:35
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC662edf2e7af1: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore.
majcosta added a commit: rSTAGING662edf2e7af1: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore.May 6 2020, 14:40

Revision Contents
Changeset List

PathSize
src/
wallet/
5 lines
55 lines

Diff 19746

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...