HomePhabricator

[LINTER] Move the string formatting function list to the python script

Description

[LINTER] Move the string formatting function list to the python script

Summary:
This change the call stack when running the lint-format-strings.sh
linter. The python script is now called once per file instead of running
once per function per file. The python script does loop internally
resulting in a large performance improvement (about 80% time cut on my
machine).

Depends on D2881.

Test Plan:

arc lint --everything

Should return no error

Comment one of the false positive at the beginning of the
lint-format-strings.py file.
Add a comment in the file from the commented false positive.

arc lint

The false positive should be catched by the linter.

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D2882

Details

Provenance
FabienAuthored on Apr 26 2019, 15:15
jasonbcoxPushed on May 1 2019, 22:52
Reviewer
Restricted Project
Differential Revision
D2882: [LINTER] Move the string formatting function list to the python script
Parents
rSTAGING305e6ce34d6e: Remove direct bitcoin access from qt/guiutil.cpp
Branches
Unknown
Tags
Unknown