HomePhabricator

qa: Use node.datadir instead of tmpdir in test framework

Description

qa: Use node.datadir instead of tmpdir in test framework

Summary:

Commit c53c983 introduced the utility function get_datadir_path, however
not all places in the code use this util function.
Using the util function everywhere makes it easier to review pull
requests related to the datadir.

This commit replaces datadir path creation with the datadir member of
TestNode, which itself uses get_datadir_path.

Backport of core PR12076
https://github.com/bitcoin/bitcoin/pull/12076/files

Test Plan:

./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3124

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 2 2018, 13:57
FabienCommitted on May 27 2019, 15:54
FabienPushed on May 27 2019, 15:59
Reviewer
Restricted Project
Differential Revision
D3124: qa: Use node.datadir instead of tmpdir in test framework
Parents
rSTAGINGdebe4fb69ad8: Don't create another wallet db directory in walletdb_tests
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/8936, tag: phabricator/base/8933, tag: phabricator/base/8927