HomePhabricator

[CMAKE] Fix DLL exports

Description

[CMAKE] Fix DLL exports

Summary:
Some symbols are missing from the libbitcoinconsensus DLL, because it
expects the preprocessor DLL_EXPORT symbol to be defined, but it is
defined by libtool only.

Test Plan:

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Use a DLL inspection tool to verify that the bitcoinconsensus_*
symbols are exported (checked with Dependency Walker
http://www.dependencywalker.com/ on windows).

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4836

Details

Provenance
FabienAuthored on Jan 6 2020, 09:20
FabienPushed on Jan 6 2020, 10:57
Reviewer
Restricted Project
Differential Revision
D4836: [CMAKE] Fix DLL exports
Parents
rSTAGINGe01f265bff44: [cmake] Make bench-secp256k1 actually run benchmarks, not simply build them.
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/15176, tag: phabricator/base/15171, tag: phabricator/base/15170, tag: phabricator/base/15169