Page MenuHomePhabricator

[CMAKE] Fix DLL exports
ClosedPublic

Authored by Fabien on Jan 6 2020, 09:32.

Details

Summary

Some symbols are missing from the libbitcoinconsensus DLL, because it
expects the preprocessor DLL_EXPORT symbol to be defined, but it is
defined by libtool only.

Test Plan
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Use a DLL inspection tool to verify that the bitcoinconsensus_*
symbols are exported (checked with Dependency Walker
http://www.dependencywalker.com/ on windows).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable