Page MenuHomePhabricator

[CMAKE] Fix DLL exports
ClosedPublic

Authored by Fabien on Mon, Jan 6, 09:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC99c02dd8892d: [CMAKE] Fix DLL exports
Summary

Some symbols are missing from the libbitcoinconsensus DLL, because it
expects the preprocessor DLL_EXPORT symbol to be defined, but it is
defined by libtool only.

Test Plan
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Use a DLL inspection tool to verify that the bitcoinconsensus_*
symbols are exported (checked with Dependency Walker
http://www.dependencywalker.com/ on windows).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Jan 6, 09:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 6, 09:32
deadalnix accepted this revision.Mon, Jan 6, 09:42
This revision is now accepted and ready to land.Mon, Jan 6, 09:42
This revision was automatically updated to reflect the committed changes.