Paths

Table of Contentst

Differential D4836

[CMAKE] Fix DLL exports
ClosedPublic
Actions

Authored by Fabien on Jan 6 2020, 09:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING99c02dd8892d: [CMAKE] Fix DLL exports
rABC99c02dd8892d: [CMAKE] Fix DLL exports

Summary

Some symbols are missing from the libbitcoinconsensus DLL, because it
expects the preprocessor DLL_EXPORT symbol to be defined, but it is
defined by libtool only.

Test Plan

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Use a DLL inspection tool to verify that the bitcoinconsensus_*
symbols are exported (checked with Dependency Walker
http://www.dependencywalker.com/ on windows).

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_dll_export

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8745
Build 15474: Default Diff Build & Tests
Build 15473: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 6 2020, 09:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2020, 09:32

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8745: Diff 15166.Jan 6 2020, 09:38

deadalnix accepted this revision.Jan 6 2020, 09:42

This revision is now accepted and ready to land.Jan 6 2020, 09:42

Closed by commit rABC99c02dd8892d: [CMAKE] Fix DLL exports (authored by Fabien). · Explain WhyJan 6 2020, 10:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC99c02dd8892d: [CMAKE] Fix DLL exports.

Fabien added a commit: rSTAGING99c02dd8892d: [CMAKE] Fix DLL exports.Apr 7 2020, 22:17

Revision Contents
Changeset List

Path

Size

cmake/

modules/

InstallationHelper.cmake

2 lines

Diff 15166

cmake/modules/InstallationHelper.cmake

Loading...