HomePhabricator

Stop translating command line options

Description

Stop translating command line options

Summary:
Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output in any way except for bitcoin-qt when a
non-English language is configured in the locale.

This implements #10962.

This is a ackport of Core PR13341

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4515

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 29 2018, 16:49
deadalnixCommitted on Nov 23 2019, 15:48
deadalnixPushed on Nov 23 2019, 16:17
Reviewer
Restricted Project
Differential Revision
D4515: Stop translating command line options
Parents
rSTAGINGc8d1fedde875: minor refactor to use ranged_for, auto and const-ness
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/14357, tag: phabricator/base/14356, tag: phabricator/base/14354