Page MenuHomePhabricator

Stop translating command line options
ClosedPublic

Authored by deadalnix on Fri, Nov 22, 22:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa7f6ea3d896b: Stop translating command line options
Summary

Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output in any way except for bitcoin-qt when a
non-English language is configured in the locale.

This implements #10962.

This is a ackport of Core PR13341

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Nov 22, 22:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 22, 22:17
Fabien accepted this revision.Sat, Nov 23, 15:33
This revision is now accepted and ready to land.Sat, Nov 23, 15:33
This revision was automatically updated to reflect the committed changes.