HomePhabricator

Do not cache version in cmake build

Description

Do not cache version in cmake build

Summary: The cmake build produce stale version numbers as a result of the caching.

Test Plan:
Build with cmake.

Increment the version number of bitcoin-abc in /CMakeLists.txt .

Rebuild, make sure the version actually changed in the generated version.h

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4228

Details

Provenance
deadalnixAuthored on Oct 8 2019, 23:48
jasonbcoxPushed on Oct 10 2019, 17:33
Reviewer
Restricted Project
Differential Revision
D4228: Do not cache version in cmake build
Parents
rSTAGING8408a0cdcf41: mempool, validation: Explain cs_main locking semantics
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/13503, tag: phabricator/base/13490, tag: phabricator/base/13487, tag: phabricator/base/13486