HomePhabricator

tests: Add missing locks to tests

Description

tests: Add missing locks to tests

Summary:
Add missing locks to tests to satisfy lock requirements (such as
EXCLUSIVE_LOCKS_REQUIRED(...) (Clang Thread Safety Analysis),
AssertLockHeld(...) and implicit lock assumptions).

This doesn't clear all the thread sanitizer issues, so running with the
tsan enabled still output a lot of errors.

Backport of core PR11623
Completes T543

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2617

Details

Committed
FabienFeb 28 2019, 10:59
Pushed
FabienFeb 28 2019, 12:34
Reviewer
Restricted Project
Differential Revision
D2617: tests: Add missing locks to tests
Parents
rSTAGINGbf562f11084b: Use cached [compact] blocks to respond to getdata messages
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/7529, tag: phabricator/base/7526, tag: phabricator/base/7523, tag: phabricator/base/7522

Event Timeline

Fabien committed rSTAGINGafadcafdac8f: tests: Add missing locks to tests (authored by practicalswift <practicalswift@users.noreply.github.com>).Feb 28 2019, 10:59