Page MenuHomePhabricator

tests: Add missing locks to tests
ClosedPublic

Authored by Fabien on Wed, Feb 27, 08:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCafadcafdac8f: tests: Add missing locks to tests
Summary

Add missing locks to tests to satisfy lock requirements (such as
EXCLUSIVE_LOCKS_REQUIRED(...) (Clang Thread Safety Analysis),
AssertLockHeld(...) and implicit lock assumptions).

This doesn't clear all the thread sanitizer issues, so running with the
tsan enabled still output a lot of errors.

Backport of core PR11623
Completes T543

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Feb 27, 08:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 27, 08:18
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Wed, Feb 27, 12:02

The changes to wallettests.cpp are not in there.

This revision now requires changes to proceed.Wed, Feb 27, 12:02
Fabien added a comment.Wed, Feb 27, 14:13

This is because there is nothing to change. When backporting PR9974 in D906 you slightly changed the PR in a way that wallettest.cpp exactly reflects what is done in PR11623.

Fabien requested review of this revision.Wed, Feb 27, 14:19
deadalnix accepted this revision.Wed, Feb 27, 15:55
This revision is now accepted and ready to land.Wed, Feb 27, 15:55
Closed by commit rABCafadcafdac8f: tests: Add missing locks to tests (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyThu, Feb 28, 10:59
This revision was automatically updated to reflect the committed changes.