Page MenuHomePhabricator

tests: Add missing locks to tests

Authored by Fabien on Feb 27 2019, 08:18.



Add missing locks to tests to satisfy lock requirements (such as
EXCLUSIVE_LOCKS_REQUIRED(...) (Clang Thread Safety Analysis),
AssertLockHeld(...) and implicit lock assumptions).

This doesn't clear all the thread sanitizer issues, so running with the
tsan enabled still output a lot of errors.

Backport of core PR11623
Completes T543

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Lint OK
No Unit Test Coverage
Build Status
Buildable 5083
Build 8229: Bitcoin ABC Buildbot (legacy)
Build 8228: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Feb 27 2019, 12:02

The changes to wallettests.cpp are not in there.

This revision now requires changes to proceed.Feb 27 2019, 12:02

This is because there is nothing to change. When backporting PR9974 in D906 you slightly changed the PR in a way that wallettest.cpp exactly reflects what is done in PR11623.

Fabien requested review of this revision.Feb 27 2019, 14:19
This revision is now accepted and ready to land.Feb 27 2019, 15:55
This revision was automatically updated to reflect the committed changes.