Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGafadcafdac8f: tests: Add missing locks to tests
rABCafadcafdac8f: tests: Add missing locks to tests

Summary

Add missing locks to tests to satisfy lock requirements (such as
EXCLUSIVE_LOCKS_REQUIRED(...) (Clang Thread Safety Analysis),
AssertLockHeld(...) and implicit lock assumptions).

This doesn't clear all the thread sanitizer issues, so running with the
tsan enabled still output a lot of errors.

Backport of core PR11623
Completes T543

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11623

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5083
Build 8229: Bitcoin ABC Buildbot (legacy)
Build 8228: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 27 2019, 08:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2019, 08:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D2607: Avoid cs_main in net_processing ActivateBestChain calls.Feb 27 2019, 08:23

Fabien added a child revision: D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.Feb 27 2019, 08:23

Harbormaster completed remote builds in B5083: Diff 7497.Feb 27 2019, 08:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

The changes to wallettests.cpp are not in there.

This revision now requires changes to proceed.Feb 27 2019, 12:02

This is because there is nothing to change. When backporting PR9974 in D906 you slightly changed the PR in a way that wallettest.cpp exactly reflects what is done in PR11623.

Fabien requested review of this revision.Feb 27 2019, 14:19

deadalnix accepted this revision.Feb 27 2019, 15:55

This revision is now accepted and ready to land.Feb 27 2019, 15:55

Closed by commit rABCafadcafdac8f: tests: Add missing locks to tests (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyFeb 28 2019, 10:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGafadcafdac8f: tests: Add missing locks to tests.Sep 18 2019, 22:33

tests: Add missing locks to tests
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 7497

src/test/DoS_tests.cpp

src/test/blockencodings_tests.cpp

src/test/mempool_tests.cpp

src/test/test_bitcoin.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/test/wallet_tests.cpp

tests: Add missing locks to testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7497

src/test/DoS_tests.cpp

src/test/blockencodings_tests.cpp

src/test/mempool_tests.cpp

src/test/test_bitcoin.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/test/wallet_tests.cpp

tests: Add missing locks to tests
ClosedPublic
Actions

Revision Contents
Changeset List