Page MenuHomePhabricator

[wallet] Construct CWalletTx objects in CommitTransaction
ClosedPublic

Authored by Fabien on Feb 27 2019, 11:45.

Details

Summary

Construct CWalletTx objects in CWallet::CommitTransaction, instead of
having callers do it. This ensures CWalletTx objects are constructed in
a uniform way and all fields are set.

This also makes it possible to avoid confusing and wasteful CWalletTx
copies in https://github.com/bitcoin/bitcoin/pull/9381

There is no change in behavior.

Partial backport of core PR9680 (commit a128bdc)
Depends on D2611

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.