Page MenuHomePhabricator
Differential D2607

Avoid cs_main in net_processing ActivateBestChain calls
ClosedPublic
Actions

Authored by Fabien on Feb 26 2019, 10:48.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls
rABCdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls
Summary

Partial backport of core PR11824 (commit a734896)
Depends on D2606

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 26 2019, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 10:48
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 26 2019, 10:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.Feb 26 2019, 11:01
teamcity added a comment.Feb 26 2019, 11:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5071: Diff 7481.Feb 26 2019, 11:01
jasonbcox mentioned this in D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.Feb 26 2019, 20:21
jasonbcox accepted this revision.Feb 26 2019, 23:48
This revision is now accepted and ready to land.Feb 26 2019, 23:48
Fabien updated this revision to Diff 7499.Feb 27 2019, 08:21

Rebase

teamcity added a comment.Feb 27 2019, 08:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 7500.Feb 27 2019, 08:23

Rebase with missing dependency: D2617

teamcity added a comment.Feb 27 2019, 08:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 7501.Feb 27 2019, 08:32

Rebase

teamcity added a comment.Feb 27 2019, 08:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 27 2019, 08:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5085: Diff 7499.Feb 27 2019, 08:34
teamcity added a comment.Feb 27 2019, 08:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5086: Diff 7500.Feb 27 2019, 08:37
teamcity added a comment.Feb 27 2019, 08:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5087: Diff 7501.Feb 27 2019, 08:45
deadalnix requested changes to this revision.Feb 27 2019, 12:21
deadalnix added inline comments.
src/net_processing.cpp
1252 ↗(On Diff #7501)

This doesn't come from here. There seems to be some older backport missing.

This revision now requires changes to proceed.Feb 27 2019, 12:21
Fabien added inline comments.Feb 27 2019, 14:18
src/net_processing.cpp
1252 ↗(On Diff #7501)

For reference I had this discussion with Jason in https://reviews.bitcoinabc.org/D2606?id=7480#inline-15905.

In the original PR the shared pointer is already there, as it requires a larger scope for segwit related stuff.
I move it in this diff because this is where the scope change occurs for us (was in the block below previously).

1266 ↗(On Diff #7501)

Moved above the block to enlarge the scope.

Fabien requested review of this revision.Feb 27 2019, 14:19
Fabien planned changes to this revision.Feb 27 2019, 14:26

After a closer look there is not only segwit stuff but also a compact block backport missing, I will rebase on top of that

Fabien updated this revision to Diff 7510.Feb 27 2019, 18:05

Rebase

teamcity added a comment.Feb 27 2019, 18:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 27 2019, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5096: Diff 7510.Feb 27 2019, 18:18
Fabien added a child revision: D2626: Re-layout comments in ProcessGetBlockData and ProcessGetData.Feb 28 2019, 11:21
deadalnix accepted this revision.Feb 28 2019, 14:22
This revision is now accepted and ready to land.Feb 28 2019, 14:22
Closed by commit rABCdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyFeb 28 2019, 18:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls.Sep 18 2019, 22:34

Revision Contents
Changeset List

PathSize
src/
35 lines

Diff 7533

View Options

src/net_processing.cpp

Loading...