Page MenuHomePhabricator

Avoid cs_main in net_processing ActivateBestChain calls
ClosedPublic

Authored by Fabien on Feb 26 2019, 10:48.

Details

Summary

Partial backport of core PR11824 (commit a734896)
Depends on D2606

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Feb 26 2019, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 10:48
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Feb 26 2019, 23:48
This revision is now accepted and ready to land.Feb 26 2019, 23:48
Fabien updated this revision to Diff 7499.Feb 27 2019, 08:21

Rebase

Fabien updated this revision to Diff 7500.Feb 27 2019, 08:23

Rebase with missing dependency: D2617

Fabien updated this revision to Diff 7501.Feb 27 2019, 08:32

Rebase

deadalnix requested changes to this revision.Feb 27 2019, 12:21
deadalnix added inline comments.
src/net_processing.cpp
1252 ↗(On Diff #7501)

This doesn't come from here. There seems to be some older backport missing.

This revision now requires changes to proceed.Feb 27 2019, 12:21
Fabien added inline comments.Feb 27 2019, 14:18
src/net_processing.cpp
1252 ↗(On Diff #7501)

For reference I had this discussion with Jason in https://reviews.bitcoinabc.org/D2606?id=7480#inline-15905.

In the original PR the shared pointer is already there, as it requires a larger scope for segwit related stuff.
I move it in this diff because this is where the scope change occurs for us (was in the block below previously).

1266 ↗(On Diff #7501)

Moved above the block to enlarge the scope.

Fabien requested review of this revision.Feb 27 2019, 14:19
Fabien planned changes to this revision.Feb 27 2019, 14:26

After a closer look there is not only segwit stuff but also a compact block backport missing, I will rebase on top of that

Fabien updated this revision to Diff 7510.Feb 27 2019, 18:05

Rebase

deadalnix accepted this revision.Feb 28 2019, 14:22
This revision is now accepted and ready to land.Feb 28 2019, 14:22
This revision was automatically updated to reflect the committed changes.