Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls
rABCdf1b1e41c632: Avoid cs_main in net_processing ActivateBestChain calls

Summary

Partial backport of core PR11824 (commit a734896)
Depends on D2606

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11824_part3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5087
Build 8237: Bitcoin ABC Buildbot (legacy)
Build 8236: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 26 2019, 10:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 10:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.Feb 26 2019, 11:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5071: Diff 7481.Feb 26 2019, 11:01

jasonbcox mentioned this in D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.Feb 26 2019, 20:21

jasonbcox accepted this revision.Feb 26 2019, 23:48

This revision is now accepted and ready to land.Feb 26 2019, 23:48

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Rebase with missing dependency: D2617

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5085: Diff 7499.Feb 27 2019, 08:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5086: Diff 7500.Feb 27 2019, 08:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5087: Diff 7501.Feb 27 2019, 08:45

deadalnix requested changes to this revision.Feb 27 2019, 12:21

deadalnix added inline comments.

src/net_processing.cpp
1252	This doesn't come from here. There seems to be some older backport missing.

This revision now requires changes to proceed.Feb 27 2019, 12:21

Fabien added inline comments.Feb 27 2019, 14:18

src/net_processing.cpp
1252	For reference I had this discussion with Jason in https://reviews.bitcoinabc.org/D2606?id=7480#inline-15905. In the original PR the shared pointer is already there, as it requires a larger scope for segwit related stuff. I move it in this diff because this is where the scope change occurs for us (was in the block below previously).
1266	Moved above the block to enlarge the scope.