HomePhabricator

Enable automatic detection of undefined names in Python tests scripts

Description

Enable automatic detection of undefined names in Python tests scripts

Summary:
Based on core PR13054.
Enforce flake8 rules:

  • F403 'from foo_module import *' used; unable to detect undefined names
  • F405 foo_function may be undefined, or defined from star imports: bar_module

Depends on D2603

Test Plan:
Add an import * directive in a functional test. Run arc lint and
check the error is reported.

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2604

Details

Provenance
FabienAuthored on Feb 24 2019, 16:35
FabienPushed on Feb 27 2019, 08:18
Reviewer
Restricted Project
Differential Revision
D2604: Enable automatic detection of undefined names in Python tests scripts
Parents
rSTAGING943fc55c8a13: Refactor the imports in the test framework
Branches
Unknown
Tags
Unknown