Page MenuHomePhabricator

Enable automatic detection of undefined names in Python tests scripts
ClosedPublic

Authored by Fabien on Feb 26 2019, 09:05.

Details

Summary

Based on core PR13054.
Enforce flake8 rules:

  • F403 'from foo_module import *' used; unable to detect undefined names
  • F405 foo_function may be undefined, or defined from star imports: bar_module

Depends on D2603

Test Plan

Add an import * directive in a functional test. Run arc lint and
check the error is reported.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Feb 26 2019, 09:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 09:05
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Feb 27 2019, 04:12
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 27 2019, 04:14
This revision was automatically updated to reflect the committed changes.