HomePhabricator

Fix arc liberate complaining about concatenation in constant definition

Description

Fix arc liberate complaining about concatenation in constant definition

Summary:
Despite constant scalar expressions are supported since PHP 5.6, XHPAST
throws a syntax error. This happens when running arc liberate which in
turn uses XPHAST.
This diffs moves the constant definion line to HEREDOC syntax instead.
It breaks the indentation as indented HEREDOC is only supported from PHP
7.3 which is fairly new and not yet part of most distributions.

Test Plan:
Should return no error:

sudo arc liberate

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: schancel

Differential Revision: https://reviews.bitcoinabc.org/D2759

Details

Provenance
FabienAuthored on Apr 1 2019, 13:04
FabienPushed on Apr 2 2019, 12:46
Reviewer
Restricted Project
Differential Revision
D2759: Fix arc liberate complaining about concatenation in constant definition
Parents
rSTAGING9d53b39b2564: [LINTER] Escape the % char in the description of PythonFormatLinter
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/7959, tag: phabricator/base/7938, tag: phabricator/base/7904