Page MenuHomePhabricator

Fix arc liberate complaining about concatenation in constant definition
ClosedPublic

Authored by Fabien on Mon, Apr 1, 13:12.

Details

Summary

Despite constant scalar expressions are supported since PHP 5.6, XHPAST
throws a syntax error. This happens when running arc liberate which in
turn uses XPHAST.
This diffs moves the constant definion line to HEREDOC syntax instead.
It breaks the indentation as indented HEREDOC is only supported from PHP
7.3 which is fairly new and not yet part of most distributions.

Test Plan

Should return no error:

sudo arc liberate

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Apr 1, 13:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 1, 13:12
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Tue, Apr 2, 01:02
This revision is now accepted and ready to land.Tue, Apr 2, 01:02
This revision was automatically updated to reflect the committed changes.