Page MenuHomePhabricator

Fix arc liberate complaining about concatenation in constant definition
ClosedPublic

Authored by Fabien on Apr 1 2019, 13:12.

Details

Summary

Despite constant scalar expressions are supported since PHP 5.6, XHPAST
throws a syntax error. This happens when running arc liberate which in
turn uses XPHAST.
This diffs moves the constant definion line to HEREDOC syntax instead.
It breaks the indentation as indented HEREDOC is only supported from PHP
7.3 which is fairly new and not yet part of most distributions.

Test Plan

Should return no error:

sudo arc liberate

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_arc_liberate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5342
Build 8746: Bitcoin ABC Buildbot (legacy)
Build 8745: arc lint + arc unit