Despite constant scalar expressions are supported since PHP 5.6, XHPAST
throws a syntax error. This happens when running arc liberate which in
turn uses XPHAST.
This diffs moves the constant definion line to HEREDOC syntax instead.
It breaks the indentation as indented HEREDOC is only supported from PHP
7.3 which is fairly new and not yet part of most distributions.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGbe1b951a84b0: Fix arc liberate complaining about concatenation in constant definition
rABCbe1b951a84b0: Fix arc liberate complaining about concatenation in constant definition
Should return no error:
sudo arc liberate
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_arc_liberate
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5342 Build 8746: Bitcoin ABC Buildbot (legacy) Build 8745: arc lint + arc unit