HomePhabricator

Mark fall-through cases in our code clearly
c1cb5aad751aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Mark fall-through cases in our code clearly

Summary:
This should help to avoid unnecessary compiler warnings.
In practice it does not seem to work right despite -Wimplicit-fallthrough=3,
but it does not hurt to clearly mark the cases already.

Links:
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix, sickpig, kyuupichan, awemany

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D224

Details

Provenance
freetraderAuthored on Jun 19 2017, 08:38
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D224: Mark fall-through cases in our code clearly
Parents
rSTAGING2d7182327797: Fixed mempool test, block size was not needed to be set to test the mempool
Branches
Unknown
Tags
Unknown