HomePhabricator

simplify checkdatasig_tests

Description

simplify checkdatasig_tests

Summary:
There's no need to force the sigops flag to be on during these tests, since
it has no impact on script evaluation.

Also, we really don't care whether or not the flag is in
MANDATORY_SCRIPT_VERIFY_FLAGS, because the code deciding ban/notban for inputs
that fail standard script evaluation does not care about sigops at all.

Test Plan: ninja check

Reviewers: Mengerian, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4908

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Jan 4 2020, 03:36
markblundebergPushed on Jan 13 2020, 01:07
Reviewer
Restricted Project
Differential Revision
D4908: simplify checkdatasig_tests
Parents
rSTAGINGc95c9b9fa75c: fix scriptSig analysis in sign.cpp
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rSTAGINGcd346ed09ac9: simplify checkdatasig_tests (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).Jan 13 2020, 00:17