Page MenuHomePhabricator

simplify checkdatasig_tests
ClosedPublic

Authored by markblundeberg on Sun, Jan 12, 05:52.

Details

Reviewers
Mengerian
deadalnix
Group Reviewers
Restricted Project
Commits
rABCcd346ed09ac9: simplify checkdatasig_tests
Summary

There's no need to force the sigops flag to be on during these tests, since
it has no impact on script evaluation.

Also, we really don't care whether or not the flag is in
MANDATORY_SCRIPT_VERIFY_FLAGS, because the code deciding ban/notban for inputs
that fail standard script evaluation does not care about sigops at all.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Sun, Jan 12, 05:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jan 12, 05:52
deadalnix accepted this revision.Sun, Jan 12, 14:36
This revision is now accepted and ready to land.Sun, Jan 12, 14:36