Paths

Table of Contentst

Diffusion Bitcoin ABC staging dcc4c33d7ce1

refactor: Remove redundant c_str() calls in formatting
dcc4c33d7ce1
Actions

Description

refactor: Remove redundant c_str() calls in formatting

Summary:
Our formatter, tinyformat, *never* needs c_str() for strings.
Remove redundant c_str() calls for:

strprintf
LogPrintf
tfm::format

This is a backport of Core PR17279

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5908

Details

Provenance

Wladimir J. van der Laan <laanwj@protonmail.com>	Authored on Oct 28 2019, 12:30
deadalnix	Committed on Apr 30 2020, 16:12
nakihito	Pushed on Apr 30 2020, 16:55

Reviewer

Restricted Project

Differential Revision

D5908: refactor: Remove redundant c_str() calls in formatting

Parents

rSTAGING4943f9ea3acc: Add settings_tests

Branches

Unknown

Tags

Unknown

Event Timeline

deadalnix added an edge: D5908: refactor: Remove redundant c_str() calls in formatting.May 5 2020, 19:15

deadalnix committed rSTAGINGdcc4c33d7ce1: refactor: Remove redundant c_str() calls in formatting (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).Apr 30 2020, 16:12

Changes (15)

Path

Size

src/

bench/

seeder/

util/

wallet/

rSTAGINGdcc4c33d7ce1

View Options

src/bench/bench_bitcoin.cpp

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/bitcoin-wallet.cpp

View Options

src/bitcoind.cpp

View Options

src/init.cpp

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/noui.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/db.cpp

View Options

src/seeder/main.cpp

View Options

src/sync.cpp

View Options

src/util/system.cpp

View Options

refactor: Remove redundant c_str() calls in formattingdcc4c33d7ce1Actions

Description

Details

Event Timeline

Changes (15)

rSTAGINGdcc4c33d7ce1

src/bench/bench_bitcoin.cpp

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoin-wallet.cpp

src/bitcoind.cpp

src/init.cpp

src/net.cpp

src/net_processing.cpp

src/noui.cpp

src/seeder/bitcoin.cpp

src/seeder/db.cpp

src/seeder/main.cpp

src/sync.cpp

src/util/system.cpp

src/wallet/wallettool.cpp

refactor: Remove redundant c_str() calls in formatting
dcc4c33d7ce1
Actions