HomePhabricator

[backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp

Description

[backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp

Summary:
psbt.cpp definitions except for AnalyzePSBT are used by the wallet and need to
be linked into the wallet binary. AnalyzePSBT is an exception in that it is not
used by the wallet, and depends on node classes like CCoinsViewCache, and on
node global variables like nBytesPerSigOp.

So AnalyzePSBT is more at home in libbitcoin_server than libbitcoin_common, and
in any case needs to be defined in a separate object file than other PSBT
utilities, to avoid dragging link dependencies on node functions and global
variables into the wallet.


Depends on D6080

This concludes the backport of Core PR15638

Test Plan:

../configure --enable-deprecated-build-system
make check
test/functional/test_runner.py

cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Reviewers: #bitcoin_abc, nakihito

Reviewed By: nakihito

Subscribers: nakihito

Differential Revision: https://reviews.bitcoinabc.org/D6084

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Apr 8 2019, 20:33
majcostaCommitted on May 16 2020, 11:49
abc-botPushed on May 16 2020, 11:50
Reviewer
nakihito
Differential Revision
D6084: [backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp
Parents
rSTAGINGaa96a2979b55: [backport#15508] Add documentation of struct PSBTAnalysis et al
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/20170