HomePhabricator

qt: Revert "Force TLS1.0+ for SSL connections"

Description

qt: Revert "Force TLS1.0+ for SSL connections"

Summary:
Backport of core PR14403

This reverts commit 15e26a6a9afe299b9ca6fced73b876644365879b, whose
purpose was to tweak the Qt configuration to force TLS, i.e., to
disable SSLv3, in Qt versions >= 5.5. However, the default behavior
of Qt >= 5.4 is to disable SSLv3 anyway [1], so the configuration
tweak is redundant.

With Qt 5.11.2, the configuration tweak is not only redundant but in
fact provokes a deadlock (#14359) due to Qt 5.11.2 being incompatible
with OpenSSL 1.1.1 [2]. Since the deadlock occurs at the early startup
stage of bitcoin-qt, it renders bitcoin-qt entirely non-functional
when compiled against OpenSSL 1.1.1 and Qt 5.11.2 (and possible future
combinations of OpenSSL and Qt versions).

This fixes the issue of bitcoin-qt not launching in Archlinux (tested,
using QT 5.12).

Test Plan:

make check
./src/qt/bitcoin-qt

Check the app launches and works as expected

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2308

Details

Provenance
Tim Ruffing <crypto@timruffing.de>Authored on Oct 5 2018, 08:24
FabienCommitted on Jan 14 2019, 14:23
deadalnixPushed on Jan 14 2019, 14:58
Reviewer
Restricted Project
Differential Revision
D2308: qt: Revert "Force TLS1.0+ for SSL connections"
Parents
rSTAGINGa428e37c8181: Various nits in the RCU mechanism
Branches
Unknown
Tags
Unknown
Reverts
rSTAGING15e26a6a9afe: qt: Force TLS1.0+ for SSL connections