HomePhabricator

Prevent wrapping in setexcessiveblock RPC

Description

Prevent wrapping in setexcessiveblock RPC

Summary:
If the blocksize parameter is a negative integer (not passed as a
string), it wraps and sets the incorrect value.
Incidently it removes the last use of boost::lexical_cast after D4080.

Test Plan:

ninja all check
./test/functional/test_runner.py abc-rpc

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5136

Details

Provenance
FabienAuthored on Feb 3 2020, 09:58
jasonbcoxPushed on Feb 3 2020, 18:07
Reviewer
Restricted Project
Differential Revision
D5136: Prevent wrapping in setexcessiveblock RPC
Parents
rSTAGING2598d7033af5: arc lint --everything
Branches
Unknown
Tags
Unknown