HomePhabricator

Fix seeder compilation warnings
e9bc0d3f5981Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix seeder compilation warnings

Summary:
Several of these on MacOSX at least

CXX seeder/libbitcoin_seeder_a-protocol.o
In file included from seeder/protocol.cpp:8:
./seeder/util.h:51:23: warning: passing an object of reference type to 'va_start' has undefined behavior [-Wvarargs]

va_start(arg_ptr, format);
                  ^

Everywhere actually passes a C string not a std::string so it seemed simplest to just switch to that.

Test Plan: make check; run binary

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D585

Details

Provenance
kyuupichanAuthored on Oct 5 2017, 13:57
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D585: Fix seeder compilation warnings
Parents
rSTAGING26bef497950b: Port of bitcoin/#10958 - leveldb patches
Branches
Unknown
Tags
Unknown